Skip to content

Conversation

@tmilkovic51
Copy link
Contributor

  • This board uses the same LCD panel like STM32H7B3I_DK board implemented in PR drivers: display: add STM32 LTDC driver #43965, so same LCD parameters are used in board device tree
  • FMC SDRAM device tree parameters were taken from STM32CubeIDE example project for this board
  • On STM32F7 series, LTDC pixel clock is supplied by PLLSAI:
    • There has been a temporary fix for configuring PLLSAI on STM32F4 and STM32F7 series in LTDC driver on commit b860402
    • Since STM32F746G_DISCO board is the only F7 board with RGB display interface supported by Zephyr, this PR changes the hardcoded F7 series PLLSAI configuration in LTDC driver, so that 9.6 MHz pixel clock is output if 25 MHz HSE is used
    • Once PR [RFC] stm32h7: Enable support for optional/alternate clocks #42097 is merged, and proper configuration for PLLSAI is implemented in clock_control driver, the PLLSAI hack can be removed from LTDC driver
  • Tested with samples/drivers/display and samples/subsys/display/lvgl samples

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. A couple of changes required

Add LTDC bindings include so boards don't have to include it

Signed-off-by: Tomislav Milkovic <[email protected]>
Add LTDC bindings include so boards don't have to include it

Signed-off-by: Tomislav Milkovic <[email protected]>
Add LTDC bindings include so boards don't have to include it

Signed-off-by: Tomislav Milkovic <[email protected]>
Add LTDC bindings include so boards don't have to include it

Signed-off-by: Tomislav Milkovic <[email protected]>
Add LTDC bindings include so boards don't have to include it

Signed-off-by: Tomislav Milkovic <[email protected]>
Add support for FMC SDRAM in board DTS
Update board doc and yaml

Signed-off-by: Tomislav Milkovic <[email protected]>
Add LTDC config and pinctrl in board DTS
Modify defconfig so KSCAN and MEMC drivers are enabled if
display is enabled
Update board doc and yaml

Signed-off-by: Tomislav Milkovic <[email protected]>
Temporary fix to configure PLLSAIR multipliers for correct
LTDC pixel clock on STM32F746G Discovery board

Signed-off-by: Tomislav Milkovic <[email protected]>
Enable pointer device and set its name in LVGL Kconfig

Signed-off-by: Tomislav Milkovic <[email protected]>
@tmilkovic51 tmilkovic51 force-pushed the stm32f746g-disco-add-display branch from 6b8132f to 250d5c8 Compare May 11, 2022 14:13
@tmilkovic51 tmilkovic51 requested a review from erwango May 11, 2022 14:19
@erwango erwango added this to the v3.1.0 milestone May 11, 2022
@carlescufi carlescufi merged commit 9a4f148 into zephyrproject-rtos:main May 12, 2022
@tmilkovic51 tmilkovic51 deleted the stm32f746g-disco-add-display branch May 13, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants